Google Git
Sign in
chromium / chromium / src / 24e5493a829e15db722664dc38a8f653e36f1044
commit24e5493a829e15db722664dc38a8f653e36f1044[log] [tgz]
authorJoanmarie Diggs <jdiggs@igalia.com>Fri Jul 15 16:18:51 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jul 15 16:18:51 2022
tree6ef425b4fc044c04b5ee4eab78e4f7fbf79bff45
parent6bf015a138b810ec01cfed0eec47267a5d40a310 [diff]
Ensure auto-disabled accessibility is re-enabled in response to API calls

When we auto-disable accessibility support due to lack of AT activity,
BrowserAccessibilityStateImpl::DisableAccessibility causes its AXMode
to be reset, but not the AXPlatformNode's AXMode. When Orca is
subsequently launched, AXPlatformNode::NotifyAddAXModeFlags returns
early because the AXMode hasn't changed.

This commit causes ResetAccessibilityMode to reset the AXPlatformNode's AXMode so that observers are notified.

AX-Relnotes: Fixed issue causing Chrome to become inaccessible to Orca
users after accessibility was auto-disabled.

Bug: 1344168
Change-Id: I2578b1c16bba77123af7e87bcb0af192552a73c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3762453
Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com>
Reviewed-by: Abigail Klein <abigailbklein@google.com>
Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1024774}
3 files changed
tree: 6ef425b4fc044c04b5ee4eab78e4f7fbf79bff45
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.