Google Git
Sign in
chromium / chromium / src / 257a9b6943bcf57aa4db344782a41a91b34674ba
commit257a9b6943bcf57aa4db344782a41a91b34674ba[log] [tgz]
authorDana Fried <dfried@chromium.org>Thu Jun 01 23:04:50 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 01 23:04:50 2023
tree4ce91ed67bbb3c603cb8f49e3f4dd5ffef43bc38
parent1c3afdc4990b544b3c3d2dfadaa78249b32a0d70 [diff]
Bubbles should inherit the same color provider as the browser window.

Currently, because things like menus, etc. can have their own color
providers, a bubble attached to a menu can inherit a different color
provider from other help bubbles.

This change makes bubbles by default inherit the color provider from
their primary window, using the current behavior as a fallback. This
will make colors in bubbles more consistent, even when windows aren't
parented consistently.

See attached bug for a case where this currently breaks.

Bug: 1450047
Change-Id: I715b2fe254624d0e273d450a97000bb22d1182d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4582227
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152212}
1 file changed
tree: 4ce91ed67bbb3c603cb8f49e3f4dd5ffef43bc38
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.