commit 257f5d563da0496b2bff67b6fde690561c91438c
author jialihuang <jialihuang@google.com> Fri Sep 01 23:27:45 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Sep 01 23:27:45 2023
tree 4f4db0a24f89d14fd5baf5233e9492a1b5e22236
parent 0101a60f635a50a57dd7c49ae98c712fcddabe45

[CVV Storage] Fix UpdateCreditCard with updated empty CVC

Change the logic when new CVC is empty:
Delete CVC record if the new CVC is empty
Every time the new CreditCard's cvc is empty, we will delete the CVC
record, thus we can ensure that existing CVC records are not empty.
(empty CVC in read-out CreditCard object == empty CVC record)

Unchanged when new CVC is not empty:
Insert if old CVC empty (Empty CVC record)
Update if old CVC is not empty (We do have old record in webdatabase)

Problem:
User have a existing card, then user update the card with empty CVC, then user try to update the card CVC again, Chrome will crash.
https://drive.google.com/file/d/1vJs3wU8gmPReGITy9FoBhKQs7vwx_0Nv/view?usp=drive_link

Cause:
old_credit_card.cvc is empty doesn't mean it doesn't exist in local_stored_cvc table. We should not use old_credit_card.cvc is empty to determine the logic to insert or update cvc into local_stored_cvc table.

Change-Id: I294743eceecb85b07b35911978636d6ce2213a12
Bug: 1473181
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4791731
Reviewed-by: Vinny Persky <vinnypersky@google.com>
Commit-Queue: Jiali Huang <jialihuang@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Siyu An <siyua@chromium.org>
Reviewed-by: Florian Leimgruber <fleimgruber@google.com>
Cr-Commit-Position: refs/heads/main@{#1191653}