Reland "Apply extent checks in both dimensions for dynamic expansion" This reverts commit b1737f5e0243bfc5c37d43249333895c7e1e6d2e. The "regressions" of record_time are expected because the cull rect is now larger in the direction with more scroll range. The original DynamicScrollCullRectExpansion code had a bug preventing the more expansion in that direction. Original change's description: > Revert "Apply extent checks in both dimensions for dynamic expansion" > > This reverts commit a3922e4113067b71f4e93c614b914e55a64e7301. > > Reason for revert: This appears to have caused a performance > regression. > > Original change's description: > > Apply extent checks in both dimensions for dynamic expansion > > > > This CL restructures the code to apply scroll extents checks in > > both dimensions in addition to clipping by the contents rect > > (this can be more constraining on the cull rect outsets in some > > cases). This CL also fixes an issue preventing outset from one > > dimension to be transferred to another in the case that the > > scroller can be scrolled in two dimensions. > > > > Bug: None > > Change-Id: I63a6b7a20723d66f02ea7cdc327f70891868ab3b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5784052 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Ian Vollick <vollick@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1342774} > > Bug: 360246807 > Change-Id: If2e5cd7460b4f882cc89fff63bfbb763116d3592 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5791713 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Ian Vollick <vollick@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1343123} Bug: 360246807 Change-Id: I92c2b23a20f5e00922873b1c01cb25ca987590b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5800774 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1344305}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.