Google GitGoogle Git
Sign in
chromium/chromium/src/25d41e19fcdab25735da18f1b52b5a9ccd14f53d
commit
25d41e19fcdab25735da18f1b52b5a9ccd14f53d
[log]
author
Christian Xu <christianxu@google.com>
Thu Jan 05 15:48:15 2023
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Thu Jan 05 15:48:15 2023
tree
acfd19a2bc38655014a0172e65b270e0c414b947
parent
4498e92d4ab03c3f080d0a196224728a8f3112e7 [diff]
[iOS][Omnibox] Fix suggestion scrolling

The table view’s content is inset to make the suggestions scrollable
above the keyboard on tablet. Disable this behavior on phone, since
scrolling dismisses the keyboard.

On iPad the selfSizingTableView sizes itself with the content size + the
content inset. This causes the table view to have a bigger height when
adding an inset to the suggestions.
This CL: Remove the content inset and replace it with
directionalLayoutMargins.

Bug: 1404701
Change-Id: I506f69241fa143a3359b4a42ad25a0e4efaac4cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4131383
Auto-Submit: Christian Xu <christianxu@chromium.org>
Commit-Queue: Christian Xu <christianxu@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1089271}
2 files changed
tree: acfd19a2bc38655014a0172e65b270e0c414b947
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.