Google Git
Sign in
chromium / chromium / src / 25e17582f3ece8dfd8766b65bff9ad8d1a5a402f
commit25e17582f3ece8dfd8766b65bff9ad8d1a5a402f[log] [tgz]
authorLijin Shen <lazzzis@google.com>Tue Jan 10 17:52:40 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 10 17:52:40 2023
tree8726e25caf07211780bde5ade67717c509afb865
parent8604e80c3a3abc8208d525ff865dc00499538bcb [diff]
Re-introduce back press handler of tab page history.

Currently, we use ToolbarTabController to track that state by
listening to events related to WebContents. But the appearance of
assertion errors proves this approach not reliable.

This CL adopts ToolbarManager as the new back press handler. The
inspiration comes from the back button in tablet toolbar.
In tablet mode, that back button tracks and indicates if
the current page can be navigated back. This CL syncs the back press
handler with that state in order to intercept the back press
correctly.

ToolbarManager updates that button's state inside updateButtonStatus
method and so the back press state is updated everytime it's triggered.

Bug: 1402783
Change-Id: I30ca5fac3820d5d5c881e228c6275a47c36a0d0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4136887
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Cr-Commit-Position: refs/heads/main@{#1090897}
11 files changed
tree: 8726e25caf07211780bde5ade67717c509afb865
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.