Google Git
Sign in
chromium / chromium / src / 25e4bc7a3beb78efeee44bc38a50229a1dba4cee
commit25e4bc7a3beb78efeee44bc38a50229a1dba4cee[log] [tgz]
authorTom Lukaszewicz <tluk@chromium.org>Fri Aug 05 20:18:19 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 05 20:18:19 2022
treef52250b6d45f62da5baac5647ad60212f4165a52
parente44239db56f3652b666cbacb24c1ac0330b2f4fd [diff]
[webui tab strip] Close the context menu when the TabStripModel changes

This CL updates the page handler to close the context menu when the tab
strip model changes.

Currently the tab strip model may remain open if the tab strip changes
in a non-interactive way (programmatically via extensions for e.g.).

This ensures that the context menu options accurately reflect the tab
strip state and avoids having performing incorrect actions that could
potentially leave the tab strip in an inconsistent state or cause
crashes.

Bug: 1350023
Change-Id: I899b78bb7a004c7c09f7214b0bb8b990de033c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3809912
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032084}
1 file changed
tree: f52250b6d45f62da5baac5647ad60212f4165a52
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.