Google Git
Sign in
chromium / chromium / src / 262eca3186442d4bcb2d46c4f60914eda5e55663
commit262eca3186442d4bcb2d46c4f60914eda5e55663[log] [tgz]
authorKoji Ishii <kojii@chromium.org>Tue Aug 10 15:43:07 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 10 15:43:07 2021
tree58b40935cb540cabfb4933f831d6916b3e2984fa
parentb1af35c7c39b20d8dce821e85a600e30ff4b76a6 [diff]
Change |NGFragmentItem::IsLastForNode| for ellipses

This patch makes sure |IsLastForNode| always matches to their
|NGPhysicalBoxFragment::BreakToken| for boxes (except inline
boxes who don't have break tokens.)

This is usually true, except when atomic inline is ellipsized.
It's so edge case that it's easy to forget to handle it
correctly. In our current code, two users of |IsLastForNode|,
one in paint and one in pre-paint, both assume |IsLastForNode|
is true for the last box fragment.

Work arounds are already put in, so there should be no visible
behavior changes, but this patch can make sure |IsLastForNode|
returns what developers expect. I'll try to clean up existing
work arounds in following patches.

Bug: 1238173
Change-Id: I26a16662b9c65297b66bafd0770477e64a1af99b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3084246
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#910321}
2 files changed
tree: 58b40935cb540cabfb4933f831d6916b3e2984fa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.