commit | 263d17d89bcac1e46af6186297f398a18c345370 | [log] [tgz] |
---|---|---|
author | Bruno Braga <brunobraga@google.com> | Tue Jun 11 17:03:52 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jun 11 17:03:52 2024 |
tree | bb2d53c4caad18469d50b1ab40d857c89f02cbd9 | |
parent | 563132dff55fc6eba08f7c1f9f60b9de753c46c8 [diff] |
Revert "tflite: generate flatbuffers files from schema with flatc" This reverts commit 05f5ebad18ee550e353823836b3eb16ddcc65a63. Reason for revert: Likely the reason for https://ci.chromium.org/ui/p/chromium/builders/ci/Deterministic%20Linux%20(dbg) The error file [1] has many mentions to tflite and this is the CL that touches it in the blame list. [1]https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8745482532584093729/+/u/compare_build_artifacts/stdout?format=raw Original change's description: > tflite: generate flatbuffers files from schema with flatc > > currently the generated flatbuffer files are checked-in to tensorflow source. > this breaks builds with unbundled flatbuffers on any version mismatch, > because flatc-generated headers have static_asserts checking if same version > of library and flatc is used. > > Bug: https://github.com/tensorflow/tensorflow/issues/62298 > Change-Id: Ie4ed9b2683acdb850e35b3861fcfbc4828f536e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5595037 > Commit-Queue: Elly FJ <ellyjones@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Elly FJ <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1312988} Bug: https://github.com/tensorflow/tensorflow/issues/62298, b/346487323 Change-Id: I4557c15468796ef3b129ee5518cbb636da55141a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5622171 Reviewed-by: Sophie Chang <sophiechang@chromium.org> Reviewed-by: David Awogbemila <awogbemila@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1313491}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.