commit | 267ea4dceb49c8fc5186d22a767bb2c9c9d2de61 | [log] [tgz] |
---|---|---|
author | Samuel Huang <huangs@chromium.org> | Mon May 13 15:44:57 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon May 13 15:44:57 2024 |
tree | 7e0397ca9ac1f31e62d67a32748321d9b5cc41c0 | |
parent | 6af14e33c7df906799a3da5fb478545d3762bcef [diff] |
[Android TRM] Move V2 results usage from Provider-level to Backend-level. Originally we envisioned Tab Resumption Module's to V2 results to be a Provider that uses JNI to access components/visted_url_ranking. The JNI was named TabResumptionBridge, and the Provider named SmartTabResumptionModuleDatProvider. It turns out that we still need to manage data freshness. Consequently, visted_url_ranking is placed at the same level as ForeignSessionHelper (agnostically called "sync derived"). How this is treated in code: * The common interface is SuggestionBackend, so far adapted only to ForeignSessionHelper. * Backend is used by SyncDerivedSuggestionEntrySource singleton. * Source is used by SyncDerivedTabResumptionDataProvider. This CL adapts the V2 results interface to use the same thing: * Remove SmartTabResumptionDataProvider. * Rename TabResumptionBridge / tab_resumption_bridge to VisitedUrlRankingBackend / visited_url_ranking_backend. * Stub SuggestionBackend overrides for now. * Builder: Use V2 usage flag to select Backend instead of Provider. Bug: 337858147 Change-Id: Ib9c9aed3dde818174cfbf659fa47df7ef330875a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5534405 Reviewed-by: Xi Han <hanxi@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300046}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.