Google Git
Sign in
chromium / chromium / src / 267ea4dceb49c8fc5186d22a767bb2c9c9d2de61
commit267ea4dceb49c8fc5186d22a767bb2c9c9d2de61[log] [tgz]
authorSamuel Huang <huangs@chromium.org>Mon May 13 15:44:57 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 13 15:44:57 2024
tree7e0397ca9ac1f31e62d67a32748321d9b5cc41c0
parent6af14e33c7df906799a3da5fb478545d3762bcef [diff]
[Android TRM] Move V2 results usage from Provider-level to Backend-level.

Originally we envisioned Tab Resumption Module's to V2 results to be
a Provider that uses JNI to access components/visted_url_ranking. The
JNI was named TabResumptionBridge, and the Provider named
SmartTabResumptionModuleDatProvider.

It turns out that we still need to manage data freshness. Consequently,
visted_url_ranking is placed at the same level as ForeignSessionHelper
(agnostically called "sync derived"). How this is treated in code:
* The common interface is SuggestionBackend, so far adapted only to
  ForeignSessionHelper.
* Backend is used by SyncDerivedSuggestionEntrySource singleton.
* Source is used by SyncDerivedTabResumptionDataProvider.

This CL adapts the V2 results interface to use the same thing:
* Remove SmartTabResumptionDataProvider.
* Rename TabResumptionBridge / tab_resumption_bridge to
  VisitedUrlRankingBackend / visited_url_ranking_backend.
  * Stub SuggestionBackend overrides for now.
* Builder: Use V2 usage flag to select Backend instead of Provider.

Bug: 337858147
Change-Id: Ib9c9aed3dde818174cfbf659fa47df7ef330875a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5534405
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300046}
10 files changed
tree: 7e0397ca9ac1f31e62d67a32748321d9b5cc41c0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.