| commit | 26bba114277e936ac439d0cca8ea65bb52eb854d | [log] [tgz] |
|---|---|---|
| author | Jonathan Lee <jonathanjlee@google.com> | Fri Jan 26 19:30:41 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 26 19:30:41 2024 |
| tree | f315737824fa6c47b9741feb83d70ddf6a8bcb72 | |
| parent | fa7c505eb236acc27c82aed8de754eedad8a71a0 [diff] |
[wpt] Don't construct unnecessary promises in `open-close.https.html`
When testing `MIDIInput.{open,close}`, `portPromise` and `accessPromise`
in `checkStateTransition()` are still constructed but not awaited.
Because `open-close.https.html` doesn't pass `access`, the latter is an
unhandled rejection that `chromedriver` detects when running the test
against `chrome` (`content_shell` seems to pass the test anyway).
Only construct the promises if needed. Also, machine-check a
precondition.
Bug: 1499775
Change-Id: I587fec95efd92d2be2733b38e0f65a0c361f5c9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5239869
Auto-Submit: Jonathan Lee <jonathanjlee@google.com>
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Commit-Queue: Michael Wilson <mjwilson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252797}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.