commit | 26c6253c48d5cccca00276cd42c812500130fe20 | [log] [tgz] |
---|---|---|
author | Tommy C. Li <tommycli@chromium.org> | Fri Jul 20 01:47:03 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jul 20 01:47:03 2018 |
tree | 9a05a2c1a43b10a4fc4c354da624f5abd85eef9d | |
parent | 43dcce8bc1451019ca9e00f89d7098f6617f72cd [diff] |
Omnibox UI Refresh: Make "invisible focus" apperance more consistent On the New Tab Page, when the user clicks the fake Google search box, i.e. the "fakebox", we give the Omnibox "invisible focus". This is a unique state where we set the Omnibox is focused and capturing key events, but the caret is invisible. In the past, the caret being invisible was sufficient for the Omnibox to be "invisibly" focused. In MD Refresh, however, we have three new focus indicators: 1. Focus ring 2. Placeholder text 3. Background color change This CL updates all three of the above visual indicators for the Omnibox to be keyed on the invisible-focus state rather than the ordinary focus state. This solves the flicker present in the below bug and actually follows the concept of invisible-focus correctly. The concept of invisible-focus is kind of evil, and long term, we would like to get rid of it -- but this is a short term fix for MD Refresh. Bug: 859826 Change-Id: I2e0ede93e69485745bbf119a3f366b0dbfa197ab Reviewed-on: https://chromium-review.googlesource.com/1144211 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#576752}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .