Google Git
Sign in
chromium / chromium / src / 27a5d56a1dc55e2410c20a6242e5c8531c48c3ea
commit27a5d56a1dc55e2410c20a6242e5c8531c48c3ea[log] [tgz]
authorDavid Benjamin <davidben@chromium.org>Wed Oct 18 20:16:30 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 18 20:16:30 2023
treeb2f19061fb64c312a4bd41e9d66930c8826c9e62
parentd1aa3a2e2032fc60b3eb691196bb8e1c81730613 [diff]
Cap the path builder iteration limit to 20

UMA reports that all validations below a rounding error (the
tool shows 100%) need 10 iterations, except on Chrome OS where the
number is 12. These numbers are also an overestimate because they
count failed validations.

Other uses of this code have picked limits of 18 and 20. Set an
upper bound of 20, which is about twice what we have any evidence
of anyone needing. The current limit is far, far too high. On the
off chance this causes an issue, add a base::Feature kill switch for a
couple releases, but I think this otherwise does not need much fanfare.

Bug: 634470
Change-Id: Ie7dd23c52b6ac0a6d3319c01767b210b4718cc3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903550
Reviewed-by: Matt Mueller <mattm@chromium.org>
Auto-Submit: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1211710}
6 files changed
tree: b2f19061fb64c312a4bd41e9d66930c8826c9e62
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.