Reland "[iOS] Adding methods to show/hide SignInPromo on the FeedTopSectionVC"

This reverts commit a10618b8a96579eb400865d1d0e473bbba99fb93.

Reason for revert: Relanding with solution for crash. The CHECK can
be removed as the flag was originally used for an experiment, and soon
the Top Section will support multiple Promos.

Original change's description:
> Revert "[iOS] Adding methods to show/hide SignInPromo on the FeedTopSectionVC"
>
> This reverts commit e457ebf58fbaa8e76bf9dc7c72ec84fdc4427d61.
>
> Reason for revert: Crashes Canary. Reverting until further investigation.
>
> Original change's description:
> > [iOS] Adding methods to show/hide SignInPromo on the FeedTopSectionVC
> >
> > Added two new methods to show and hide the SignInPromo on the
> > FeedTopSectionViewController that can be called directly to change the
> > visibility of the promo in question.
> >
> > Change-Id: I23d4dd34d09216f460b18d539b36f45befe607ce
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4887842
> > Auto-Submit: Guillem Perez <guiperez@google.com>
> > Reviewed-by: Adam Arcaro <adamta@google.com>
> > Commit-Queue: Guillem Perez <guiperez@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1209724}
>
> Change-Id: Ibeea5a1a7f6fa57624aba3869119d6d9ba4ab233
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4940890
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Auto-Submit: Guillem Perez <guiperez@google.com>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1210168}

Change-Id: If0c5bdc22c46842ecc4c78d31ed6e62786c53b7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4944190
Auto-Submit: Guillem Perez <guiperez@google.com>
Commit-Queue: Guillem Perez <guiperez@google.com>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210432}
5 files changed
tree: c6e491edad1a709e8d4c3228ce7f9f8d8b1f3139
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.