Google Git
Sign in
chromium / chromium / src / 27da4f6460254aaea3669bbbafa8c10aefad4515
commit27da4f6460254aaea3669bbbafa8c10aefad4515[log] [tgz]
authorVasiliy Telezhnikov <vasilyt@chromium.org>Tue Nov 19 15:10:35 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 19 15:10:35 2024
treed331995c61d8d3ffa7dfd17cec7d9d0132762dfc
parent2cf8d566266ea60ee2ecaaca777a9fd2ac0be473 [diff]
Remove flip_y from DrawingBuffer::GetUnacceleratedStaticBitmapImage

The only callsite gets the flag from the origin of the unaccelerated
CanvasResourceProvider. The only CRP that can have bottom left origin
is CanvasResourceProviderPassthrough and it's accelerated, so the flag
was always `!GetDrawingBuffer()->IsOriginTopLeft()`

Inside drawing buffer that would result in:

origin_top_left = !opengl_flip_y_extension_ ? opengl_flip_y_extension_
                                            : !opengl_flip_y_extension_;

Which is always false.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc;l=1926;drc=af973fd11814a739cf0327ad657442262d38ca47;bpv=1;bpt=0

Change-Id: Ia0df523b0644d003b813b8b56f094777bd9b457e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001027
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1384947}
3 files changed
tree: d331995c61d8d3ffa7dfd17cec7d9d0132762dfc
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.