Google Git
Sign in
chromium / chromium / src / 27f536d06aee26e3fc46ede841a652fa7111b307
commit27f536d06aee26e3fc46ede841a652fa7111b307[log] [tgz]
authorNihar Majmudar <niharm@google.com>Tue Jan 09 16:22:56 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 09 16:22:56 2024
tree8cf8e9da27c546fcd15b77005f9ffe09c6d8337b
parent06dcec6fcd1e0567a607d45dec1065b492110290 [diff]
[realbox][cr23] Fix hover fill shape for non-inlined action matches.

This change introduces a new div that is only triggered when
OmniboxActionsUISimplification is disabled, chrome refresh hover fill
shape is on, and when a match has an action associated with it. The
underneath action chip is moved to inside this div so the hover shape
can sorround the entire match. In every other case, this div is hidden.
This will make it easy to clean up once OmniboxActionsUISimplification
is launched since this is the only case where the bug is triggered.

To test, disable #omnibox-actions-ui-simplification and enable
#ntp-realbox-cr23-expanded-state-icons,
#ntp-realbox-cr23-expanded-state-layout,
#ntp-realbox-cr23-hover-fill-shape.

Before: https://screenshot.googleplex.com/cbsShcqYAjQPkzN
After: https://screenshot.googleplex.com/74zSZUAEL6smhg6

Bug: 1515956
Change-Id: I8230784e409d5a6206e7e4fbfd0b61b7ebbb7662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5174110
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Nihar Majmudar <niharm@google.com>
Reviewed-by: Khalid Peer <khalidpeer@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1244701}
2 files changed
tree: 8cf8e9da27c546fcd15b77005f9ffe09c6d8337b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.