Handle the context getting discarded in NormalizeAlgorithm

The WebCrypto result machinery tracks when the context was discarded
to cancel the operation, if still pending. However, that logic did not
correctly account for the context being discarded before the task is
posted:

- CryptoResultImpl::Resolver DCHECKs that the context is valid when
  it is created. As far as I can tell, that DCHECK isn't necessary?

- If CryptoResultImpl::Cancel is called before calling
  CryptoResultImpl::Result, the cancel flag is null, which breaks
  WebCryptoResult's DCHECKs and null pointer derefs later in release
  code.

Instead, remove the DCHECK and retain the cancel flag in CryptoResultImpl
so WebCryptoResult can observe cancelation in either order.

These two changes fix the crashes. This CL additionally makes
webcrypto_impl.cc check for cancellation before posting the task. This
isn't strictly necessary, but avoids a pointless thread hop.

Bug: 1324846
Change-Id: Idd8f2174f438fc3bfb5ffd140b9983d5b6b8039d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3664759
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1008433}
3 files changed
tree: 80170b015bd46a3aab8f0b37d531a5b394fe4905
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.