Return early if creating a CanonicalCookie from a CookieCraving fails Changes in this CL: - In addition to creating a CanonicalCookie in ShouldIncludeForRequest, create it in CanonicalCookie::Create as well. If that fails, return early, which will prevent a session from being created in the first place. - When creating a CanonicalCookie in ShouldIncludeForRequest, return false instead of dereferencing a nullptr in the case where creation fails. - Add DumpWithoutCrashing logging for both of these early returns. Bug: 435221694 Change-Id: Ie133561d10531851726757d87a4fbeb01ae55009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6840877 Commit-Queue: thefrog <thefrog@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/main@{#1501509}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.