Google Git
Sign in
chromium / chromium / src / 280f080d143b197c97e4c31f0a2330c48756e730
commit280f080d143b197c97e4c31f0a2330c48756e730[log] [tgz]
authorJames Hawkins <jhawkins@chromium.org>Thu Jul 19 18:42:16 2018
committerCommit Bot <commit-bot@chromium.org>Thu Jul 19 18:42:16 2018
tree4bce33884c4af714701e1445c2506cbcde961c1d
parentff1eab6792bc012492f1ebcb1f042c520fe2d838 [diff]
EasyUnlockPrivateApi: Fix crash circumstances on shutdown.

* Declare BrowserContextKeyedAPIFactory dependency on
  ApiResourceManager, which EasyUnlockPrivateConnectionManager directly
  depends on.
* Don't try to deref if the returned connections list is null.

For the sake of posterity, I was unable to reproduce these crashes, but
it appears they are happening in the wild under unknown circumstances.
This change contains hardening for real issues, so monitoring of crash
reports once this change goes out is required.

R=khorimoto@chromium.org

Bug: 850765
Test: none
Change-Id: I347a6c4126e8b02f9caea14adeb81dc9b9b26aff
Reviewed-on: https://chromium-review.googlesource.com/1143599
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576573}
4 files changed
tree: 4bce33884c4af714701e1445c2506cbcde961c1d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .