| commit | 281090b4a2a42fb230270c87ef49e49f95ea89ef | [log] [tgz] |
|---|---|---|
| author | Will Cassella <cassew@google.com> | Wed Aug 11 00:25:17 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Aug 11 00:25:17 2021 |
| tree | b096f429e6a741d3527b3c03a5310a8d7fc55359 | |
| parent | 42f8f835e70bb1d03e7572c2a3290053680c51e3 [diff] |
Release internal lock before running ChunkDemuxer::open_cb_ (passed in during construction), in what is effectivately a tail-call. It may be useful to, for example, run |ChunkDemuxer::AddId| within that callback but if the lock is still held then Chrome will crash. This CL ensures that the lock is released before running the callback (and adds a unit test to avoid regressing), which is safe due to the call being a tail-call. ChunkDemuxer: :Initialize results in a call to ChunkDemuxer::open_cb_ Change-Id: If4d843bd452dfa19bbd62c788e7b1bce9ba8db58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3088152 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#910593}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.