Google Git
Sign in
chromium / chromium / src / 2895a61453c2d94b90bdcd8a80050a5224085075
commit2895a61453c2d94b90bdcd8a80050a5224085075[log] [tgz]
authorJoe Downing <joedow@chromium.org>Tue Jul 30 18:22:45 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jul 30 18:22:45 2024
tree30f3be29f81c1e3d9119888e1e80f43b51fd21ba
parentbcddd7dd4b6d02b409f95e6cb6d591b659494cf1 [diff]
Fixing a regex parsing issue in the host wrapper script

We received a report that setting up a host on Ubuntu 24.04 results in this error being logged:
daemon_controller_delegate_linux.cc(98)] /opt/google/chrome-remote-desktop/chrome-remote-desktop:2526: SyntaxWarning: invalid escape sequence '\s'
  re.split('\s+', os.environ[HOST_EXTRA_PARAMS_ENV_VAR].strip())

It looks like this was added for the Wayland work and was probably fine at the time, but now we only support Python 3 and we either need to escape the backslash or use a raw string.

AFAICT this is a benign error at the moment but we should still try to fix it.

Change-Id: I0bdb7f5dc47717f2750a9103b25f55e5e49480bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5749208
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334989}
1 file changed
tree: 30f3be29f81c1e3d9119888e1e80f43b51fd21ba
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.