| commit | 28a131c6be0d25616d64835262d04b16cb7a0f68 | [log] [tgz] |
|---|---|---|
| author | Andrey Kosyakov <caseq@chromium.org> | Thu Sep 08 16:37:35 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 08 16:37:35 2022 |
| tree | 0a9ccae258d14aa93cc163c1f745a0a3a2cb25ce | |
| parent | 2cd54a09dba66c27297795c3bedbafd7da630de9 [diff] |
Auto-attach portals via Tab rather than Frame target
- introduce a session attribute to indicate client supports tab target;
- stop auto-attaching portals for sessions descending from tab targets;
- attach all "main frame" targets through the Tab target (this should
include Portals and other (sub)types that will be covered later).
Drive-by:
- split DevToolsSession constructor for root and child targes;
- fix a typo that may have caused instability of target-filter.js test;
Bug: 1348385
Change-Id: Ib77b2f24016598b913e6945a8166293f2f87a723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3820608
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1044602}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.