commit 28e1c4543cbf2ec2d71d1b1c751b9e74b68c78f8
author Yao Qijing <yaoqq@google.com> Fri Mar 25 03:43:21 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Mar 25 03:43:21 2022
tree 0e8290b632585a029327309b1993acfb74d67ff7
parent d1fd530a951a6797a5b113d0dcff034c90197e1a

Close compat menu if entry button is clicked again

Currently if compat mode button is clicked when the compat menu is
shown, the menu is closed and then gets shown again. It's an unnatural
UX since the user would expect a toggle effect for the button.
This CL fixes the issue by adding a check before (re-)showing the menu,
which is based on a weak pointer of the menu bubble.
Also need to note that in this implementation, the close action (when
the button is clicked when bubble is shown) relies on the delayed
destruction of the bubble object which is triggered by activation change
of the menu bubble.

R=toshikikikuchi

      --gtest_filter="*ResizeToggleMenuTest.TestIsBubbleShown"

Test: Manual testing
Test: ash_components_unittests \
Bug: b/192514067
Change-Id: I41dbabf985aee9c205810a771cf10a22663e1d93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3539609
Reviewed-by: Toshiki Kikuchi <toshikikikuchi@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Qijing Yao <yaoqq@google.com>
Cr-Commit-Position: refs/heads/main@{#985166}