Google Git
Sign in
chromium / chromium / src / 2947584bd780e6f4c238dee2589e77220b7bc096
commit2947584bd780e6f4c238dee2589e77220b7bc096[log] [tgz]
authorLukasz Anforowicz <lukasza@chromium.org>Tue Nov 22 18:29:17 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 22 18:29:17 2022
tree4bebc3cbae774b7cb121b78b318531bbb120a92f
parent9c4ef63598e36bab0a169c11e219ae3949f03254 [diff]
Add RenderFrameHostImpl::AssertBrowserContextShutdownHasntStarted.

This CL adds AssertBrowserContextShutdownHasntStarted method to
RenderFrameHostImpl, because we speculate that the root cause for
https://crbug.com/1376879 is that a BrowserContext (e.g. a Profile)
destruction got initiated without first closing all WebContents.  (If
all WebContents were closed then RenderFrameHostImpl would be deleted
and wouldn't be handling BeginNavigation as in the bug.)

After this CL, if the bug repros then
1. A new crash key should log the creator of the WebContents that
   wasn't closed when it should have been.
2. The unbound factory in `non_network_factories` will be skipped.

Bug: 1376879
Change-Id: I42d7802583ff260e402ef05b8de77791ebca273b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4034960
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1074754}
3 files changed
tree: 4bebc3cbae774b7cb121b78b318531bbb120a92f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.