Google Git
Sign in
chromium / chromium / src / 29b7ee5f4948dba48cbc5757b4b167c17454ea5d
commit29b7ee5f4948dba48cbc5757b4b167c17454ea5d[log] [tgz]
authorCalder Kitagawa <ckitagawa@chromium.org>Mon Aug 19 17:34:51 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Aug 19 17:34:51 2024
tree8f814f5d2a5faafae39f1a8b5dd031d5ddf71782
parent44190aa4079168329e4c8b667d4329e9d43c2fa0 [diff]
[Thumbnails] Refactor ThumbnailProvider and Fetcher

Refactor ThumbnailProvider and ThumbnailFetcher to use a more
conventional argument order where the callback is the last argument.
Change the callback everywhere to take a Drawable rather than a Bitmap
in preparation for MultiThumbnailProvider to return a LayerDrawable
instead of a BitmapDrawable in the future.

Create a standalone ThumbnailFetcher to replace
TabListMediator.ThumbnailFetcher. The new fetcher supports cancelation
of in-flight callbacks and a follow-up CL will call cancel
appropriately when the THUMBNAIL_FETCHER is changed.

Bug: 342450242
Change-Id: I151e77f1d4d3814746d2f077a81d4ce36571cb21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5792463
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Brandon Wylie <wylieb@google.com>
Cr-Commit-Position: refs/heads/main@{#1343588}
31 files changed
tree: 8f814f5d2a5faafae39f1a8b5dd031d5ddf71782
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. CRYPTO_OWNERS
  78. DEPS
  79. DIR_METADATA
  80. LICENSE
  81. LICENSE.chromium_os
  82. OWNERS
  83. PRESUBMIT.py
  84. PRESUBMIT_test.py
  85. PRESUBMIT_test_mocks.py
  86. README.md
  87. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.