Google Git
Sign in
chromium / chromium / src / 2a137720e54938bbf6c8ac35a03ba3c528cfa665
commit2a137720e54938bbf6c8ac35a03ba3c528cfa665[log] [tgz]
authorPranav Modi <pranavmodi@microsoft.com>Wed Apr 16 16:42:15 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 16 16:42:15 2025
tree8c93889752729a4b049a4bcd1036b320286e2be3
parent9cf9befa7d98c4cf2d6363024e24e680c234318f [diff]
[Editing] Prevent adding newline character after space key press

The issue involved the textarea where pressing the space key before any
character in multi-line wrapped content caused unwanted newline
characters. This bug was introduced by the change list [1]. A line break
was automatically added so that spaces appeared at the caret. This logic
has now been removed. Typing spaces at the start of a wrapped line was
confusing because the spaces ended up in the previous line. To address
this, the caret's affinity has been changed from downstream to upstream
whenever possible. This adjustment ensures the caret is positioned
correctly and spaces inserted are properly visible.

There is an issue [2] filed on w3c for the expected specification
change.

[1] - https://codereview.chromium.org/2618613004

[2] - https://github.com/w3c/editing/issues/482

Bug: 40677155
Change-Id: Ida00847e32ef9c2efdd7ddde38d798528947593f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254377
Reviewed-by: Sambamurthy Bandaru <sambamurthy.bandaru@microsoft.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Pranav Modi <pranavmodi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1447804}
5 files changed
tree: 8c93889752729a4b049a4bcd1036b320286e2be3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.