commit | 2a257fc9cbf9460c37f897735770a0b13f4d4ef8 | [log] [tgz] |
---|---|---|
author | Friedrich Horschig <fhorschig@chromium.org> | Thu Sep 02 17:20:53 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 02 17:20:53 2021 |
tree | 21e644289f3a7783e7bdc542202e7dd2f4896877 | |
parent | 27b468250ee2c0fd524c83aa0189c5e3de422f01 [diff] |
Reland "[Android][Passwords] Get Passwords from ChromeSync" This is a reland of 719c10d0fb48e9bdacc491f9e7afcd343903585c Excluding the *impl from the jar broke the build when no downstream implementation was present. That implementation is in https://crrev.com/i/4086348 but the latter needs the interface defined here. Therefore, this CL only defines interface and build structure now and the use and public impl follow in https://crrev.com/c/3139999. Original change's description: > [Android][Passwords] Get Passwords from ChromeSync > > This CL forwards requests to a downstream implementation and forwards > the responses to the caller of GetLogins(), e.g. in the old settings UI. > > To achieve that, an interface is defined and instantiate by an abstract > factory whose implementation lives downstream. The tests also live there > since the entire android-specific implementation is unused in public > builds that keep using the cross-platform, local store backend. > > In order to test or run this CL, you will need to include the API > changes from https://crrev.com/i/4086348 and build with: > > enable_chrome_android_internal = true # to fetch the API SDK > use_signing_keys = true # to talk to the 1st party API > > Change-Id: I8c56f08728eed42c4379d01ca8fcbba212254a56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2704560 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/main@{#917169} Bug: 1229654, 1245727 Change-Id: I7844607048e5a3560a62540d39f181285c9b0567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3138512 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/main@{#917726}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.