Google Git
Sign in
chromium / chromium / src / cab486564089576c77fb3e6c75e71f0bb54fa4d6
commitcab486564089576c77fb3e6c75e71f0bb54fa4d6[log] [tgz]
authorNoémie St-Onge <noemies@google.com>Wed Apr 17 21:24:08 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Apr 17 21:24:08 2024
treedd94fb25ebd00f137d9691bf2ed1c6083273dd04
parentc679dc5325f1aa6b494218f5b974630889279ead [diff]
[iOSKAUpgrade] Create new manual fill password cell header

This CL creates the manual fill password cell's header for the upcoming
Keyboard Accessory Upgrade feature. This change:
- Sets a minimal height constraint for the header view.
- Adjusts the padding above and under the header view.
- Adds a separator between the header and rest of the cell.

Note: The `CreateHeaderView` method is going to be re-used for the
payment cell's header, which is going to be implemented in a subsequent CL.

Before/After comparison with KA Upgrade disabled (there should be no changes): https://screenshot.googleplex.com/9ZHGAtvQJCmGoxz.png

Before/After comparison with KA Upgrade enabled:
https://screenshot.googleplex.com/94AYHHriEgMhebv.png

Before/After comparison with KA Upgrade enabled and a subtitle:
https://screenshot.googleplex.com/5966Ly7j8mVq6cv.png

Mocks: go/ios-keyboard-accessory-upgrade-mocks

Fixed: 326413235
Change-Id: I2d482d7605ea8748e70d681be3e8ade080ce763e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5406172
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Noémie St-Onge <noemies@google.com>
Cr-Commit-Position: refs/heads/main@{#1288986}
5 files changed
tree: dd94fb25ebd00f137d9691bf2ed1c6083273dd04
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.