Fix toolbelt disappearance on '@' input or empty input in keyword mode This CL fixes two scenarios where the toolbelt could disappear from the match list: - When entering only '@' as omnibox input, toolbelt was cut from list for special keyword mode refresh behavior. Restoring to list, it was out of order because this special case input had special sorting logic. Fix is flag guarded and simpler/more-general than previous reordering logic. - When entering any keyword mode with no additional input text, the toolbelt was excluded because the provider was initiating actual async requests and later clearing matches. Fix was to restrict this behavior to only '@page' mode as originally designed, but '@page' mode is not officially supported so more work may be needed to get toolbelt and '@page' mode working well together. Bug: 424504345 Change-Id: I12e4e4c2250fded7058993fc16405d07c2e69394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6680172 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by: Orin Jaworski <orinj@chromium.org> Reviewed-by: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1480696}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.