Google Git
Sign in
chromium / chromium / src / 2a9e5a8e80157e791fd8cf72401d4b6e0b22bc92
commit2a9e5a8e80157e791fd8cf72401d4b6e0b22bc92[log] [tgz]
authorKeren Zhu <kerenzhu@chromium.org>Thu Jul 14 22:16:38 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 14 22:16:38 2022
tree662566f6b09305bda34d5bbc037a3224c2189c25
parent1a0fda374ee20bf87af62787a0b8a1ec485cbfcf [diff]
[M103] Reland "Fix UaF in media router dialog"

This is a reland of commit 6bb25233f4fae8519b185d08e9ba4ad90c372e4f

Some tests in the previous attempt failed because they were not waiting
for the async dialog close event. Fix that.

Original change's description:
> Fix UaF in media router dialog
>
> Dialog cleanup was done in OnWidgetClosing(), which will not be called
> if the dialog is destroyed by the platform. Use OnWidgetDestroying()
> instead.
>
> Bug: 1308341, 1240365
> Change-Id: Ifca4c2fdebc0947e0efdfffbf4f53f97855ada51
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3614727
> Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
> Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1001140}

(cherry picked from commit 0cbff252e961eadb7b273155859ef989ff60d629)

Bug: 1308341, 1240365
Change-Id: I2e914a599e2f985371f37defa4129852e86ad214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3638233
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003141}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3763585
Reviewed-by: Mike Wasserman <msw@chromium.org>
Auto-Submit: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#1226}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
5 files changed
tree: 662566f6b09305bda34d5bbc037a3224c2189c25
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.