Google Git
Sign in
chromium / chromium / src / 2aa3e115f1275e30efcea0cc8271da73b1aeba3e
commit2aa3e115f1275e30efcea0cc8271da73b1aeba3e[log] [tgz]
authorZhiyuan Cai <zhiyuancai@chromium.org>Tue May 17 23:15:01 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 17 23:15:01 2022
treeb56e22c5dcfbf2b24f725261b99f9fb422568544
parent34f09c4bb5cf8737e3cf1b94174d182dd10320fb [diff]
[PriceTracking] Get subscriptions manager on menu item select

Now we get the subscription manager on Chrome activity initialization
and use it on menu item select. If user enables MSBB or signs in after
Chrome starts and then goes to a PDP, the menu item is visible but no
response on click because subscription manager is null. We should get
the manager at that time instead to fix it.

(cherry picked from commit ab6554711ffba985b0e82888983282af7f1cf7e2)

Bug: 1319271
Change-Id: I6427b7017a8f8643332742e472d754fee4498d2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3635145
Auto-Submit: Zhiyuan Cai <zhiyuancai@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003859}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652599
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: Zhiyuan Cai <zhiyuancai@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#60}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
1 file changed
tree: b56e22c5dcfbf2b24f725261b99f9fb422568544
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.