Google Git
Sign in
chromium / chromium / src / 2ac21f3796e75f6a60f17bb3516ea2093d5aa6c9
commit2ac21f3796e75f6a60f17bb3516ea2093d5aa6c9[log] [tgz]
authorRune Lillesveen <futhark@chromium.org>Fri Aug 20 15:16:21 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Aug 20 15:16:21 2021
treed38ce6c06c9663660b223f7b1e71c3d7aa9a57f3
parent752dd2d846bd89a7819086419a51a790efba75eb [diff]
[@container] Interleave style/layout on first pass

Design document:
https://docs.google.com/document/d/1mpN2I0KYVmIoB8LfSV3pzPAoqGBIrubybHPzrhc2dxA/edit#bookmark=id.3v9o1qnhg95u

The current implementation of style/layout interleaving does a full pass
over the tree for UpdateStyleAndLayoutTree() which leads to multiple
passes over elements for which container queries change.

In this CL, we introduce the ability to skip style recalc for subtrees
where we can be certain will be reached by the subsequent
UpdateLayout(). The implementation is currently disabled for all configs.

The cases we can guarantee that we will reach a container during layout
are if it is explicitly marked for layout, or will have the layout tree
re-attached. We will still potentially need to do two passes when the
container changes its size due to size changes for any of its ancestor
containers.

The following test is failing with the flag enabled because of
crbug.com/1239143:

virtual/container-queries/wpt_internal/css/css-conditional/container-queries/at-container-005.html

This CL also depends on the following CL for not failing whitespace re-
attachment tests:

https://chromium-review.googlesource.com/c/chromium/src/+/3070919

Bug: 1146097
Change-Id: I6c0be6ae770574387a0b9103b6c950d0c31b356b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2982116
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#913804}
15 files changed
tree: d38ce6c06c9663660b223f7b1e71c3d7aa9a57f3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.