Google Git
Sign in
chromium / chromium / src / cb7b25e820b8619116e178498b282204862e25f2
commitcb7b25e820b8619116e178498b282204862e25f2[log] [tgz]
authorOwen Min <zmin@chromium.org>Mon Jan 15 17:15:12 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Jan 15 17:15:12 2024
tree4f5037d92ac227fffea62814ebb0ef0a44e72e75
parent71c082db73cc90bed83d0b71a917178f5206e8c8 [diff]
Revert "Allow variable service path."

This reverts commit c1ee185a12e66294bf2f7525d3cc2040111a042b.

Reason for revert: 
FetcherConfigTest.StaticPathCrashesForNonEmptyArgs is failing
consistently on linux-chromeos-chrome
First failure:
https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/38612/overview

Original change's description:
> Allow variable service path.
>
> Keeps the requisite that the path's value is a string literal, but allows defining templates that will be interpolated in the runtime.
>
> Bug: b:317321035
> Change-Id: I2860a659da08a33293f99ee7f1324bd1e639fa2b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5195915
> Reviewed-by: Duong Dac <ddac@chromium.org>
> Auto-Submit: Tomek Jurkiewicz <tju@google.com>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Commit-Queue: Duong Dac <ddac@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1247117}

Bug: b:317321035
Change-Id: I2514fcd4fc6edf53c58b38907aba4be9be0c50e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5197931
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Owen Min <zmin@chromium.org>
Auto-Submit: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247227}
9 files changed
tree: 4f5037d92ac227fffea62814ebb0ef0a44e72e75
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.