soul: Add feature flag for gravedigger
This adds the feature flag that will be queried on the platform side by
services interacting with gravedigger to check if they should use the
new functions or rely on the previous implementation.
Bug: b:320672077
Change-Id: I81db13a0ecb9f40fac176a0910b3121a8528b273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5340214
Reviewed-by: Jan Láník <janlanik@google.com>
Commit-Queue: Christoph Schlosser <cschlosser@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1283033}
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index c0d34e35..f86aa90e 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -11190,6 +11190,12 @@
FEATURE_VALUE_TYPE(features::kAndroidNoSurfaceSyncForBrowserControls)},
#endif // BUILDFLAG(IS_ANDROID)
+#if BUILDFLAG(IS_CHROMEOS_ASH)
+ {"cros-soul-gd", flag_descriptions::kCrosSoulGravediggerName,
+ flag_descriptions::kCrosSoulGravediggerDescription, kOsCrOS,
+ PLATFORM_FEATURE_NAME_TYPE("CrOSLateBootGravedigger")},
+#endif // BUILDFLAG(IS_CHROMEOS_ASH)
+
// NOTE: Adding a new flag requires adding a corresponding entry to enum
// "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
// Histograms" in tools/metrics/histograms/README.md (run the
diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
index 3b76839..3d012ee 100644
--- a/chrome/browser/flag-metadata.json
+++ b/chrome/browser/flag-metadata.json
@@ -1642,6 +1642,11 @@
"expiry_milestone": 135
},
{
+ "name": "cros-soul-gd",
+ "owners": [ "cschlosser@chromium.org", "cros-privacy-features-dev@google.com" ],
+ "expiry_milestone": 135
+ },
+ {
"name": "cros-web-app-install-dialog",
"owners": [ "loubrett@google.com", "cros-apps-platform-core@google.com" ],
"expiry_milestone": 130
diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
index 3144770..d4f1aae 100644
--- a/chrome/browser/flag_descriptions.cc
+++ b/chrome/browser/flag_descriptions.cc
@@ -5834,6 +5834,9 @@
const char kCrosSoulName[] = "CrOS SOUL";
const char kCrosSoulDescription[] = "Enable the CrOS SOUL feature.";
+const char kCrosSoulGravediggerName[] = "CrOS SOUL Gravedigger";
+const char kCrosSoulGravediggerDescription[] = "Use Gravedigger.";
+
const char kCrosBatterySaverName[] =
"Enable ChromeOS Battery Saver Mode Support";
const char kCrosBatterySaverDescription[] =
diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
index e377c09..b8be4f31 100644
--- a/chrome/browser/flag_descriptions.h
+++ b/chrome/browser/flag_descriptions.h
@@ -3391,6 +3391,9 @@
extern const char kCrosSoulName[];
extern const char kCrosSoulDescription[];
+extern const char kCrosSoulGravediggerName[];
+extern const char kCrosSoulGravediggerDescription[];
+
extern const char kCrosWebAppShortcutUiUpdateName[];
extern const char kCrosWebAppShortcutUiUpdateDescription[];
diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
index 9949ace..5e94ad1 100644
--- a/tools/metrics/histograms/enums.xml
+++ b/tools/metrics/histograms/enums.xml
@@ -18699,6 +18699,7 @@
<int value="-1024687559" label="ShortcutCustomization:enabled"/>
<int value="-1024644761" label="OmniboxShortcutBoost:enabled"/>
<int value="-1024065253" label="EnableWireGuard:disabled"/>
+ <int value="-1024018413" label="CrOSLateBootGravedigger:disabled"/>
<int value="-1022971520" label="enable-search-button-in-omnibox-for-str"/>
<int value="-1022290134" label="WebApkInstallFailureRetry:disabled"/>
<int value="-1022281869" label="ArcRtVcpuDualCore:enabled"/>
@@ -23922,6 +23923,7 @@
<int value="1319725131" label="enable-distance-field-text"/>
<int value="1320201920" label="enable-touchpad-three-finger-click"/>
<int value="1320450434" label="ArcUsbStorageUI:disabled"/>
+ <int value="1322013438" label="CrOSLateBootGravedigger:enabled"/>
<int value="1323808967" label="PlaybackSpeedButton:disabled"/>
<int value="1324043544" label="SyncSettingsCategorization:enabled"/>
<int value="1324080668" label="VcControlsUi:disabled"/>
