Google Git
Sign in
chromium / chromium / src / 2b67fc235eeb9cc40e88b5dbfc9af3c8366ff0f1
commit2b67fc235eeb9cc40e88b5dbfc9af3c8366ff0f1[log] [tgz]
authorChris Harrelson <chrishtr@chromium.org>Fri Oct 27 01:52:47 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Oct 27 01:52:47 2023
tree92379a1ca7b0a7a1183fd9161c7527a491a2f62d
parent1850fa325b0efbb6eb5fdac5946f804c4041b95e [diff]
Avoid crashes when calling computedName or computedRole from DevTools

The crash involves re-entrance to the rendering lifecycle.

The lifecycle is supposed to be at pre-paint clean when these methods are called from devtools. However, the methods can also be called from
the (not-shipped) AOM JS APIs. The code that checked for the lifecycle
state in those methods was a hack to avoid re-entrant lifecycles. CL
4976744 revealed a situation when the lifecycle was not up-to-date
(still don't know how); in those situations, return an empty string
to avoid crashing.

This CL also migrates DevTools to use a method that is guaranteed not
to re-enter the lifecycle, which is a best practice for such situations.

Fixed: 1496369

Change-Id: Ibeffd0169291897e208da6860320951078663153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4979375
Auto-Submit: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1215890}
5 files changed
tree: 92379a1ca7b0a7a1183fd9161c7527a491a2f62d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.