commit | 2b798e975c6cdb02dee93bdaf184276ad21d4be9 | [log] [tgz] |
---|---|---|
author | Etienne Pierre-doray <etiennep@chromium.org> | Wed Oct 03 17:38:41 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 03 17:38:41 2018 |
tree | 070253be5e58097a474fc3f748927bac8044c872 | |
parent | ab81ed65a4d788b68cccfa6c25817864bf9c9a50 [diff] |
[TaskScheduler]: Use ScopedBlockingCall to mark blocking tasks. This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api/braille_display_private. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=aboxhall@chromium.org Bug: 874080 Change-Id: I3f749884b51d34136fff66d253ef71e2be34a335 Reviewed-on: https://chromium-review.googlesource.com/1191233 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#596274}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .