Google Git
Sign in
chromium / chromium / src / 2b8d7102a2380eda2b10332284007104e8f05db0
commit2b8d7102a2380eda2b10332284007104e8f05db0[log] [tgz]
authorCalder Kitagawa <ckitagawa@chromium.org>Tue Nov 08 17:55:47 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 08 17:55:47 2022
tree0045fa97468795f10839f24ffe4ba6e758e0ec94
parenta15f89c799dae5ff76653c3e9845fc093934915d [diff]
[Android Bulk Tab Edit] Close Chrome if closing all tabs in last group

Repro:
1. Open a single tab group and have all tabs inside it.
2. Use the bottom toolbar to open the Tab Group UI.
3. Close all tabs via TabSelectionEditorV2

Expected:

No more tabs and in tabbed context -> exit chrome

Actual:

Chrome offers the undo snackbar with the rest of the UI frozen until
the snackbar disappears and Chrome exits.

This does not affect cases where Chrome is in the GTS unless the
close Chrome with 0 tabs homepage policy is applied.

The fix is to treat multiple pending tab closures the same as other
cases where there are no tabs and close Chrome. This has been the case
since this logic was first added. Likely because this scenario was
not possible at the time [1]

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1525134

Bug: 1381462
Change-Id: I5d70d08088d509cae1cb2951a0c5073d0358817e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4008664
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1068632}
2 files changed
tree: 0045fa97468795f10839f24ffe4ba6e758e0ec94
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.