Google Git
Sign in
chromium / chromium / src / 2b9204dc5da70092fb75090f55717ddde4f8e299
commit2b9204dc5da70092fb75090f55717ddde4f8e299[log] [tgz]
authorRebekah Potter <rbpotter@chromium.org>Fri Jun 17 18:24:23 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jun 17 18:24:23 2022
tree471a0d0b081261405f678c17e4ed0224e897b029
parent9c877841affa06f41f9c1188581aaffd304c899e [diff]
Sync Internals: Replace cr/ui/list with a simple custom list

cr/ui/list is deprecated and contains a lot of logic/optimizations that
are leftover from when it was used for large user facing UIs like
bookmarks and settings, and are not needed for this internal debug
page. To facilitate removing cr/ui/list from builds, replace its use in
components/sync/driver/resources with minimal custom list display
logic.

This also makes it feasible to migrate sync internals to TypeScript in
the future, since cr/ui/list and cr/ui/array_data_model are not
supported for TypeScript pages.

Bug: 1322977
Change-Id: I0c84d18bbc975c09377a7f31e70ce2c4f18c2772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708128
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1015437}
6 files changed
tree: 471a0d0b081261405f678c17e4ed0224e897b029
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.