Google Git
Sign in
chromium / chromium / src / 2ba010df6e9fa8da5f5116a3349964107fa9946e
commit2ba010df6e9fa8da5f5116a3349964107fa9946e[log] [tgz]
authorTom Lukaszewicz <tluk@chromium.org>Tue Jun 07 20:39:19 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 07 20:39:19 2022
tree9bbe2017a69e1e57a439688052d877c06028d63f
parent6ba6a01d30d4ec64e4755a223a3c090c4ba170af [diff]
[M103 Merge][webui tabstrip] Use the ColorProvider to retrieve tab group colors

Currently TabStripPageHandler::GetTabGroupData() gets the
ColorProvider ColorId for the tab group in question and passes it to
TabStripUIEmbedder::GetColor(). However the implementation of this
interface calls into ThemeProvider::GetColor(). This ultimately
results in us retrieving an incorrect color for the tab group.

This CL fixes this by ensuring we pull the color from the WebUI's
ColorProvider directly.

(cherry picked from commit 5d8c899642ad59245e209c168fc7fe8a2d0107df)

Bug: 1332350
Change-Id: I2cc50e0565363308510b504fa11c1f86e089542e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3688673
Reviewed-by: Yuheng Huang <yuhengh@chromium.org>
Auto-Submit: Thomas Lukaszewicz <tluk@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1010437}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3693859
Cr-Commit-Position: refs/branch-heads/5060@{#653}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
1 file changed
tree: 9bbe2017a69e1e57a439688052d877c06028d63f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.