| commit | 36a44e742c06d181f4a84f95ca0f3b3565a96a52 | [log] [tgz] |
|---|---|---|
| author | Mikel Astiz <mastiz@chromium.org> | Mon Jul 08 10:16:26 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 08 10:16:26 2024 |
| tree | 33eaa11fe05867b115fe3c0640f4c8c1035b6018 | |
| parent | 068dcb4daae8940cb9250ea78cb1d1b346b86e9a [diff] |
[ios] Migrate BookmarkPathCache away from LegacyBookmarkModel Usage of LegacyBookmarkModel is getting replaced with bookmarks::BookmarkModel. The specific case of BookmarkPathCache, tackled in this patch, implies that the bookmark's node ID is sufficient to uniquely identify a bookmark node, as there is exactly one BookmarkModel instance (as opposed to having two, which was the case until recent cleanups). This also means the second preference, namely "ios.bookmark.cached_folder_model", becomes unused. It is still kept around and written to as a safety net and rollback path in case recent code changes run into issues. On the calling site, in BookmarksHomeViewController, LegacyBookmarkModel continues to be used as the migration is complex, to be tackled in future patches. Temporarily, it exercises LegacyBookmarkModel::underlying_model() to access the underlying bookmarks::BookmarkModel instance, requiring that the two injected LegacyBookmarkModel instances share the very same underlying BookmarkModel (which is guaranteed in practice). Bug: 346918509 Change-Id: Ife26ea58b35260fae1f38afa4d1cba54d868aa01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5678973 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1324125}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.