commit 2bcb03071fef1491671fe5128cf7c8d596aa0077
author Fredrik Söderquist <fs@opera.com> Tue Jun 03 11:24:24 2025
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 03 11:24:24 2025
tree bf38954dee1071bb8fc4c919577ff37efb539af4
parent d519005dd157048584c499c0acbd828984ed7422

Use base::Time::FromUTCString() in ParseDate()

This switches from ParseDateFromNullTerminatedCharacters() to the
base::Time equivalent in ParseDate().

Based on data collected by the use counters:

 https://chromestatus.com/metrics/feature/timeline/popularity/5128 and
 https://chromestatus.com/metrics/feature/timeline/popularity/5129

there are some differences. The relevant cases in which the parsers
differ has been identified as:

1) Unrecognized timezone labels. For example KST, MSK, EEST, YEKT and
   BST.

2) The base::Time parser accepts trailing garbage, like:

    * "Mon, 02 Jun 2025 11:55:15 CEST (cached)",
    * "Mon, 02 Jun 2025 10:04:55 GMT, Mon, 02 Jun 2025 10:04:55 GMT" and
    * "Mon, 02 Jun 2025 10:06:26 GMT GMT"

3) The base::Time parser accepts a timezone offset before the timezone
   label or without a separating space, like:

    * "Sat, 24 May 2025 11:13:11 +0300 GMT" and
    * "2025-06-01T21:07:14-03:00"

4) The ParseDateFromNullTerminatedCharacters() produce incorrect
   date/time for dates that are in the future, like:

    * "Wed, 11 Apr 2035 09:34:46 GMT" (wrong day)
    * "Wed, 08 Nov 2051 17:56:46 GMT" (wrong day)
    * "Tue, 19 Jan 2038 03:14:07 GMT" (wrong day)
    * "Mon, 31 Dec 2040 00:00:00 GMT" (wrong day)
    * "Tue, 19 Jan 2038 03:14:07 GMT" (wrong day)
    * "Sun, 05 Dec 2032 16:06:02 +0000" (wrong hour)

Bullet point (4) should be enough motivation to switch. In all cases,
the base::Time parser is more correct or accepting.

Guarded by flag "ParseDateUsesBaseTimeFromUtcString".

Bug: 375343405
Change-Id: Ic75ced160773b8c6b7db0444cc20c1e5c3c399cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6611178
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1468635}