commit | 364c0486848f637297d55992783d77bfd1ca06d9 | [log] [tgz] |
---|---|---|
author | manuk <manukh@chromium.org> | Fri Feb 15 22:26:03 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 15 22:26:03 2019 |
tree | 2a8e3e76579ef5bf9fdcf02979587979226e866f | |
parent | b30a8cecae6bf176cb5f94ece93be0c200653e86 [diff] |
Reland "[omnibox]: Initialize HistoryURLProvider earlier." This is a reland of 6e200e4f600e2eb0258e244177aa9439ff0b6bb4 Original change's description: > [omnibox]: Initialize HistoryURLProvider earlier. > > This CL moves the HistoryURlProvider's initialization after the SearchProvider's > but before the ZeroSuggestProvider's and ClipboardURLProvider's. > > For threading reasons, CL 1384637 moved the HistoryURlProvider's initialization > last in the AutocompleteController's constructor. However, the zero suggest and > clipboard URL providers take a reference of the history URL provider when > initialized. To avoid setting these references to NULL, this CL moves the > history URL provider's initialization before the other two's but keeps > it after the search provider's for the reasons described in the other CL. > > Bug: 932257 > Change-Id: I1085ad89e13f29ea29264ce3fa1a2d33197f3b17 > Reviewed-on: https://chromium-review.googlesource.com/c/1474383 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632682} Bug: 932257 Change-Id: If1dd04d838bc78f8f323280b4023fea551a80b3a Reviewed-on: https://chromium-review.googlesource.com/c/1475249 Reviewed-by: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#632793}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .