Ensure callback is cancelled before being cleared or overwritten. * Move some Cancels earlier and add Cancels to some paths. * Set the "PendingResponse" values in a single place, with a Cancel immediately beforehand. * Add DCHECK that callback is already disposed in DestroyOnDeviceState. Also fixes an unrelated get->reset typo that fixes some histogram logging. Change-Id: If6f15290b6a556f4eb29377bfd6a0096775e1436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5420240 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1282575}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.