Avoid dangling pointer in Combobox unit test. This CL replaces a raw pointer member variable to the combobox that is being tested by a getter that obtains it from the looking it up by its ID inside the widget's ContentView. All other changes in the test are renamings combobox_ -> combobox(). Bug: 1469136 Change-Id: Ibd8ba936c981cb954db3f8875a8de68fe3633d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4939213 Reviewed-by: Elly FJ <ellyjones@chromium.org> Commit-Queue: Elly FJ <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1210214}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.