AppShims: Use correct directory for crash reporting. One of the crash reporting directories is derived by getting user data dir from PathService. Swapping the initialization order fixes that case. The actual crash dumps however instead use the "default" user data dir. To make sure that takes the correct browser channel into account, this CL also fixes chrome::ProductDirName() to look at chrome's app bundle rather than the shim's app bundle by switching from chrome::OuterAppBundle to base::apple::OuterBundle (the base version is generally initialized to whatever the chrome:: version returns; except in app shims where the chrome version doesn't return the chrome app, and the base version is instead initialized with different logic to use the correct bundle). Bug: 40807881 Change-Id: I7645d26176390209c132c2d63492a5db6cb932cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6952237 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1516291}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.