Google Git
Sign in
chromium / chromium / src / 2c823ceaefa4212b3719bfe1ab480489c891d732
commit2c823ceaefa4212b3719bfe1ab480489c891d732[log] [tgz]
authorVikram Pasupathy <vpasupathy@chromium.org>Thu Jan 18 20:43:36 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 18 20:43:36 2024
treec3ef1b4e3b486218efd1ce3094ed32288f4ebc7a
parentfc1f02ecab3a77c8e5787bf7f9e8226caf3c9c16 [diff]
media: Fix bug related to UpgradeDatabaseSchema

The comment in the CL covers it pretty clearly, but to recap:

The CL upgrading the DatabaseSchema only set the meta_table's Version
Number and not CompatibleVersionNumber. This meant that the second and
onwards usage of the CdmStorageDatabase, a call to
UpgradeDatabaseSchema would be called in OpenDatabase() and would
fail, leading to no writes being allowed, since the SQL would fail as
we are trying to add a column that is already added.

This CL fixes this by fixing the underlying issue, adding a check so
that we can catch this and set the meta_table's version properly, and
adds a unittests to verify that closing and opening the database the
second time around still works as expected.

Bug: 1454512
Change-Id: Ie5a6f160f5b1c192888ed87b7a7069419dd663a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5206434
Auto-Submit: Vikram Pasupathy <vpasupathy@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Vikram Pasupathy <vpasupathy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1249012}
3 files changed
tree: c3ef1b4e3b486218efd1ce3094ed32288f4ebc7a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.