disk_cache: Make Backend::GetEntryCount asynchronous

This change converts `disk_cache::Backend::GetEntryCount()` to an
asynchronous method. The primary motivation is the planned `SqlBackend`
implementation, which will not maintain the entry count on the backend's
live sequence. Retrieving this value requires a hop to a different
sequence, making a synchronous API unsuitable.

Outside of test code, `GetEntryCount()` is currently only used by the
`BlockFile` backend implementation. Other backends only use this method
in tests. This limited production scope makes the migration to an
asynchronous API manageable.

The change propagates up the call stack to consumers of this API, such
as `GpuDiskCache` and `PnaclTranslationCache`, making their equivalent
`Size()` methods asynchronous as well.

Existing backend implementations now conform to the new asynchronous
interface. For `blockfile::BackendImpl`, the previous synchronous logic
has been moved to a new private method, `GetEntryCountSync()`. A new
`net::TestInt32CompletionCallback` is also introduced to simplify
updating the numerous affected unit tests.

Bug: 422065015
Change-Id: Ic2d8c1e1c3a7a6b86479b33e2e545c138abc77b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6646584
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1474730}
35 files changed
tree: b25e620fb3b47af5a75c5939eaf1c555e0103636
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. SECURITY_OWNERS
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.