[Autofill] Move FormFieldData::section_ to AutofillField

This CL moves the `Section` member from FormFieldData in core/common
to AutofillField in core/browser.

That's necessary because we'll determine FillingProduct- and perhaps
even EntityType-specific Sections. The necessary types aren't visible
in core/common.

As a result, this CL moves and deletes quite bit of code and includes
one ugly hack:

- Good: It moves the class Section to autofill_field.h.
- Good: It moves FormFieldData::section_ to AutofillField::section_.
- Good: It deletes FormFieldData::FillData::section.
- Good: It deletes all the Mojo code for Sections.
- Bad: It adds a hacky Section parameter to
  AutofillDriver::ApplyFormAction(). This parameter is only needed for
  and used by iOS. The reason is that Bling still implements "Clear
  Form" rather than "Undo Autofill", and "Clear Form" resets all fields
  of in the same section as the trigger field. To this end, on iOS, the
  renderer still needs to know which section the filled fields belong
  to. This parameter has an appropriately bulky name. It can be deleted
  when Bling replaces "Clear Form" with "Undo Autofill".

Bug: 430871528, 40232021
Change-Id: I447b5a11390f060fdb6654db3db6efec5eb6fb78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6725674
Reviewed-by: Vincent Boisselle <vincb@google.com>
Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Jihad Hanna <jihadghanna@google.com>
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Jan Keitel <jkeitel@google.com>
Cr-Commit-Position: refs/heads/main@{#1486270}
32 files changed
tree: 5f21112ca6df7604f2e5e7e636732bf0cc285ba8
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. SECURITY_OWNERS
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.