Revert "Delete unreachable "update gms" in PasswordManagerErrorMessageDelegate"

This reverts commit 14f71c8c59c1085573ebebc56fef8a5caefb229e.

Reason for revert: PasswordGenerationFrameHelperTest failures on
"android-automotive-12l-x64-rel-tests" (https://crbug.com/440019138)

Bug: 433684502
Original change's description:
> Delete unreachable "update gms" in PasswordManagerErrorMessageDelegate
>
> This is a follow-up to crrev.com/c/6832195.
> PasswordManagerClient::ShowPasswordManagerErrorMessage() does nothing
> for kGMSCoreOutdatedSavingPossible and kGMSCoreOutdatedSavingDisabled
> these days. The enum values can be deleted, along with the corresponding
> UI code.
> https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/password_manager/chrome_password_manager_client.cc;l=523;drc=c711efae5816b0a02668f4aca7f9bd94ad3860bb
>
> Semi-related, this CL also replaces
> PasswordFeatureManager::ShouldUpdateGmsCore() with a direct call
> to IsGmsCoreUpdateRequired(), since the latter is equally easy to
> unit test.
>
> OBSOLETE_HISTOGRAMS=The "update gms" password manager message was deleted.
>
> Bug: 433684502
> Change-Id: Ic9d8addef1db64adbd6de06a724a9c9b4229f270
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6862993
> Auto-Submit: Victor Vianna <victorvianna@google.com>
> Reviewed-by: Friedrich Hauser <friedrichh@chromium.org>
> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1503877}

Bug: 433684502, 440019138
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ife78f05c0c33cc7977036dd5806c23e6dbbe5226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6863279
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Alex Ilin <alexilin@google.com>
Cr-Commit-Position: refs/heads/main@{#1503983}
27 files changed
tree: 710d8f32f0908cb1579f83d9778bd9797e05776a
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.