commit 2cd3cfc737691c6f54b00b650002e6580d67b9e7
author Victor Hugo Vianna Silva <victorvianna@google.com> Wed Jun 05 08:46:18 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Jun 05 08:46:18 2024
tree 7e0023bee4e525f892aaa4c39e9e0ba16ef26955
parent b37cedfad928827603acf8145992f3ee267e39de

[passwords] Handle signed-in users in isGmsCoreUpdateRequired()

Changes are behind flag because kPasswords is only in
SyncUserSettings::GetSelectedTypes() if
kEnablePasswordsAccountStorageForNonSyncingUsers is enabled.
Changes in this CL:

1) Rather than have PasswordManagerUtilBridge#isGmsCoreUpdateRequired()
and PasswordManagerUtilBridge#shouldUseUpmWiring() take an
isPwdSyncEnabled boolean, have them take the SyncService and compute
the boolean internally. The pro for the boolean is it reduces the API
surface, but the con is callers can compute the bool differently. The
code already had TODOs proposing this change, I suspect it was deferred
because there was no way to plumb the SyncService across JNI boundaries.
This CL adds such JNI support.

2) Update isGmsCoreUpdateRequired() to handle signed-in non-syncing
users exactly like syncing users, i.e. drop the IsSyncFeatureEnabled()
check. shouldUseUpmWiring() is *NOT* updated, it seems to really care
about syncing users.

3) Do similar to (2) in the passwords_counter.cc caller, so the code
looks reasonable.

Note: I wanted to split (1) to a precursor CL without behavior changes,
but that's hard because:
a) calling IsSyncFeatureEnabledIncludingPasswords() in
IsGmsCoreUpdateRequired() causes cyclic dependencies
b) some callers already hardcode true for isPwdSyncEnabled.
https://source.chromium.org/chromium/chromium/src/+/main:chrome/android/java/src/org/chromium/chrome/browser/sync/settings/SyncSettingsUtils.java;l=149;drc=b7d797ba31cc6613ee20ae1ac495999b50cf1c1a

Bug: 344609691
Change-Id: Ia43cb4b0e2fdde55c2ddbcad3209b2fe313c83e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5593790
Auto-Submit: Victor Vianna <victorvianna@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1310489}